[PATCH] D40129: [ELF] Fall back to search dirs for linker scripts specified with -T

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM with these changes.



================
Comment at: ELF/DriverUtils.cpp:217
+    return Name.str();
+  else if (Optional<std::string> Path = findFromSearchPaths(Name))
+    return Path;
----------------
Remove `else` since the last `if` ends with `return`.



================
Comment at: ELF/DriverUtils.cpp:219
+    return Path;
+  return None;
+}
----------------
Instead of returning None, directly return `findFromSearchPaths(Name)`.


================
Comment at: test/ELF/linkerscript/linker-script-in-search-path.s:20
+# RUN: llvm-readobj %t.out | FileCheck %s
+
----------------
Please remove the redundant trailing newline.


https://reviews.llvm.org/D40129