[PATCH] D40125: [ELF] Fix rewriting of --sysroot in reproducer tars

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 21:19:54 PST 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/DriverUtils.cpp:163
     case OPT_symbol_ordering_file:
     case OPT_version_script:
       OS << Arg->getSpelling() << " " << quote(rewritePath(Arg->getValue()))
----------------
arichardson wrote:
> ruiu wrote:
> > Can't you just add `case OPT_sysroot` here?
> Indeed, that's much better. I didn't realize that lld also accepts `--sysroot` without the equals
Please sort alphabetically.


https://reviews.llvm.org/D40125





More information about the llvm-commits mailing list