[PATCH] D38790: [ELF] Do not keep symbols if they referenced only from discarded sections.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 14:55:41 PST 2017


Igor Kudrin via Phabricator <reviews at reviews.llvm.org> writes:


>      // See "Global Data Symbols" in Chapter 6 in the following document:
>      // ftp://www.linux-mips.org/pub/linux/mips/doc/ABI/mipsabi.pdf
>      ElfSym::MipsGp = Symtab->addAbsolute<ELFT>("_gp", STV_HIDDEN, STB_LOCAL);
> +    ElfSym::MipsGp->Live = true;

Please refactor this so we don't end up with a lot of "foo = ...;
foo->Live = true"

Thanks,
Rafael


More information about the llvm-commits mailing list