[PATCH] D40160: All .xdata sections are eligble for ICF

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lld/COFF/ICF.cpp:83
   bool Writable = C->getPermissions() & llvm::COFF::IMAGE_SCN_MEM_WRITE;
-  return C->isCOMDAT() && C->isLive() && Global && Executable && !Writable;
+  return C->isCOMDAT() && C->isLive() &&
+         ((Global && Executable && !Writable) ||
----------------
ruiu wrote:
> I'd add `bool Xdata` for consistency.
I want to short-circuit the section name string comparison, though. How about this?


https://reviews.llvm.org/D40160