[PATCH] D40148: [AMDGPU] Fix SITargetLowering::lowerEXTRACT_VECTOR_ELT for constant type

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 08:05:17 PST 2017


yaxunl added a comment.

In https://reviews.llvm.org/D40148#928236, @arsenm wrote:

> SplitInteger,
>  where default pointer type is used for the constant 16.
>
> This is wrong. This should not be using getIntPtrConstant. For AMDGPU the shift type is always 32. If somewhere is creating a shift mask with something other than getScalarShiftAmountTy, that is a bug there.


I see. Will fix SplitInteger to use getScalarShiftAmountTy.


https://reviews.llvm.org/D40148





More information about the llvm-commits mailing list