[llvm] r318409 - [FuzzMutate] Fix windows build after rL318407.

[Alex Bradbury via llvm-commits]

On 16 November 2017 at 16:17, Igor Laevsky via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: igor.laevsky
> Date: Thu Nov 16 08:17:32 2017
> New Revision: 318409
>
> URL: http://llvm.org/viewvc/llvm-project?rev=318409&view=rev
> Log:
> [FuzzMutate] Fix windows build after rL318407.
> Add correct library dependence.
>
>
> Modified:
>     llvm/trunk/lib/FuzzMutate/LLVMBuild.txt
>
> Modified: llvm/trunk/lib/FuzzMutate/LLVMBuild.txt
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/FuzzMutate/LLVMBuild.txt?rev=318409&r1=318408&r2=318409&view=diff
> ==============================================================================
> --- llvm/trunk/lib/FuzzMutate/LLVMBuild.txt (original)
> +++ llvm/trunk/lib/FuzzMutate/LLVMBuild.txt Thu Nov 16 08:17:32 2017
> @@ -19,4 +19,4 @@
>  type = Library
>  name = FuzzMutate
>  parent = Libraries
> -required_libraries = Analysis Core Scalar Support Target
> +required_libraries = Analysis BitReader BitWriter Core Scalar Support Target

Hi Igor. This commit and r318407 are breaking my local builds. I'm
building with -DBUILD_SHARED_LIBS=True -DLLVM_USE_SPLIT_DWARF=True
-DLLVM_OPTIMIZED_TABLEGEN=True.

 Linking CXX executable bin/llvm-demangle-fuzzer
FAILED: bin/llvm-demangle-fuzzer
: && /usr/bin/clang++-3.8   -fuse-ld=gold -fvisibility-inlines-hidden
-std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual
-Wmissing-field-initializers -pedantic -Wno-long-long
-Wnon-virtual-dtor -Wno-comment -fcolor-diagnostics -g
-Wl,-allow-shlib-undefined
-Wl,-rpath-link,/home/asb58/scratch/llvm-repos/llvm/build_for_upstream/./lib
tools/llvm-demangle-fuzzer/CMakeFiles/llvm-demangle-fuzzer.dir/DummyDemanglerFuzzer.cpp.o
tools/llvm-demangle-fuzzer/CMakeFiles/llvm-demangle-fuzzer.dir/llvm-demangle-fuzzer.cpp.o
 -o bin/llvm-demangle-fuzzer  lib/libLLVMDemangle.so.6.0.0svn
lib/libLLVMFuzzMutate.so.6.0.0svn -lpthread
-Wl,-rpath,"\$ORIGIN/../lib" && :
tools/llvm-demangle-fuzzer/CMakeFiles/llvm-demangle-fuzzer.dir/DummyDemanglerFuzzer.cpp.o:../tools/llvm-demangle-fuzzer/DummyDemanglerFuzzer.cpp:llvm::VerifyEnableABIBreakingChecks:
error: undefined reference to 'llvm::EnableABIBreakingChecks'

I've confirmed that ninja bin/llvm-demang-fuzzer works just fine
before r318407, and fails after r318407 and r318409. Unfortunately I
don't know enough about EnableABIBreakingChecks to suggest what might
be going wrong here.

Best,

Alex