[PATCH] D40125: [ELF] Fix rewriting of --sysroot in reproducer tars

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 19:42:41 PST 2017


ruiu added inline comments.


================
Comment at: ELF/DriverUtils.cpp:163
     case OPT_symbol_ordering_file:
     case OPT_version_script:
       OS << Arg->getSpelling() << " " << quote(rewritePath(Arg->getValue()))
----------------
Can't you just add `case OPT_sysroot` here?


================
Comment at: ELF/DriverUtils.cpp:168
+    case OPT_sysroot:
+    OS << Arg->getSpelling() << "=" << quote(rewritePath(Arg->getValue()))
+         << "\n";
----------------
Indentation?


https://reviews.llvm.org/D40125





More information about the llvm-commits mailing list