[PATCH] D40129: [ELF] Fall back to search dirs for linker scripts specified with -T
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 16 19:08:25 PST 2017
ruiu added inline comments.
================
Comment at: ELF/Driver.cpp:867
+ if (Optional<MemoryBufferRef> MB = readFile(*Path))
+ readLinkerScript(*MB);
+ } else {
----------------
Early-break after this line.
================
Comment at: ELF/DriverUtils.cpp:223
+// options accumulate.
+
+Optional<std::string> elf::searchLinkerScript(StringRef Name) {
----------------
By convention, we don't have a blank line between a function comment and a function definition.
================
Comment at: ELF/ScriptParser.cpp:355
if (Optional<MemoryBufferRef> MB = readFile(*Path))
tokenize(*MB);
+ } else {
----------------
Please return after this line. In general, we prefer early return/break/continue.
https://reviews.llvm.org/D40129
More information about the llvm-commits
mailing list