[PATCH] D39775: [asan] Test ASan instrumentation for shadow scale value of 5

[Walter Lee via Phabricator via llvm-commits]

waltl marked an inline comment as done.
waltl added inline comments.


================
Comment at: llvm/test/Instrumentation/AddressSanitizer/test64.ll:1
-; RUN: opt < %s -asan -asan-module -S | FileCheck %s
+; RUN: %opt_asan < %s -asan -asan-module -S | FileCheck --check-prefixes=CHECK,CHECK-S%scale %s
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
----------------
vitalybuka wrote:
> Looks to complicated. I'd prefer if you:
> 1. don't move files into ShadowScale3
> 2. Remove %opt_asan 
> 3. remove asan_test_shadow_scale and just add additional RUN: in tests where it makes sense. E.g.:
> 
> ; RUN: %opt < %s -asan -asan-module -S | FileCheck --check-prefixes=CHECK,CHECK-S3 %s
> ; RUN: %opt -asan-mapping-scale=5 < %s -asan -asan-module -S | FileCheck --check-prefixes=CHECK,CHECK-S5 %s
> 
> 
Done.  I selectively enabled some tests; it seems that the stack-poisoning/stack_layout tests are useful as well but they are harder to port, so perhaps I'll do that in a separate commit.



https://reviews.llvm.org/D39775