[PATCH] D40122: [WIP] Add isl to LLVM repository.

[Eugene Zelenko via Phabricator via llvm-commits]

Eugene.Zelenko added inline comments.


================
Comment at: lib/ISL/CMakeLists.txt:55
+endfunction ()
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/CMakeLists.txt:90
+endif ()
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/CMakeLists.txt:105
+endif ()
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/CMakeLists.txt:120
+endif ()
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/CMakeLists.txt:135
+endif ()
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/CMakeLists.txt:152
+endif ()
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/CMakeLists.txt:159
+configure_file("isl_srcdir.c.cmake" "${ISL_BINARY_DIR}/isl_srcdir.c")
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/CMakeLists.txt:285
+target_compile_options(LLVMISL PRIVATE ${ISL_DISABLE_WARNINGS_FLAGS})
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/isl_config.h.cmake:6
+#define GCC_WARN_UNUSED_RESULT @GCC_WARN_UNUSED_RESULT@
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/isl_config.h.cmake:18
+#define HAVE_DECL__BITSCANFORWARD @HAVE_DECL__BITSCANFORWARD@
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/isl_config.h.cmake:27
+#define HAVE_DECL__STRICMP @HAVE_DECL__STRICMP@
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/isl_config.h.cmake:36
+#define HAVE_DECL__STRNICMP @HAVE_DECL__STRNICMP@
+
+
----------------
Please remove duplicated empty line.


================
Comment at: lib/ISL/isl_config.h.cmake:45
+#define HAVE_DECL__SNPRINTF @HAVE_DECL__SNPRINTF@
+
+
----------------
Please remove duplicated empty line.


https://reviews.llvm.org/D40122