[PATCH] D40110: Use TempFile in dsymutil

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 11:54:04 PST 2017


JDevlieghere added inline comments.


================
Comment at: tools/dsymutil/dsymutil.cpp:324
     llvm::SmallVector<MachOUtils::ArchAndFilename, 4> TempFiles;
+    std::vector<sys::fs::TempFile> TempFileStore;
+    TempFileRemover Remover{TempFileStore};
----------------
What do you think about moving the vector into the RAII object? 


https://reviews.llvm.org/D40110





More information about the llvm-commits mailing list