[PATCH] D40136: [ARM] Fix missed vpadd combine opportunity.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a reviewer: efriedma.
efriedma added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:9423
 
+static SDValue AddCombineVUZPToVPADD(SDNode *N, SDValue N0, SDValue N1,
+                                      TargetLowering::DAGCombinerInfo &DCI,
----------------
Please rename this, or refactor the code, so the difference between AddCombineToVPADD and and this function is clear.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:9432
+  if (!(N0.getOpcode() == ISD::EXTRACT_SUBVECTOR &&
+        N1.getOpcode() == ISD::EXTRACT_SUBVECTOR))
+    return SDValue();
----------------
Do you need to check the index of the EXTRACT_SUBVECTORs?


================
Comment at: test/CodeGen/ARM/vpadd.ll:406
+  ret void
+}
+
----------------
I'd like to see more tests, to make sure we have some test coverage for cases where the combine isn't legal.


https://reviews.llvm.org/D40136