[PATCH] D39864: Fix for CFI type tests lowering assert.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/lib/IR/Value.cpp:477
       if (!isa<GlobalValue>(C)) {
         C->handleOperandChange(this, New);
         continue;
----------------
I think the only way that you can end up replacing multiple users during an iteration of this loop is if this function gets called. So could you instead collect a set of constants that you need to call handleOperandChange on and take care of them separately after the loop?


https://reviews.llvm.org/D39864