[PATCH] D40029: [ELF] Only add contiguous isRelro sections to PT_GNU_RELRO PHDR

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In https://reviews.llvm.org/D40029#927193, @peter.smith wrote:

> Adding pcc as the original author of https://reviews.llvm.org/D28272.
>
> Peter, in  https://reviews.llvm.org/D28272#637284 you mention that you'd add a follow up patch that used .data.rel.ro rather than .bss.rel.ro for the copy relocations. I can't work out if that ever landed. Can you let me know if did? I've just ran into a case where the assumptions made by a ld.bfd linker script cause problems with the .bss.rel.ro name.


No, the use of NOBITS is deliberate. See http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170102/417025.html

Could we instead rename .bss.rel.ro to .data.rel.ro only if the linker script has a SECTIONS clause?


https://reviews.llvm.org/D40029