[PATCH] D39772: [asan] Add lit feature for custom shadow scale

[Walter Lee via Phabricator via llvm-commits]

waltl added inline comments.


================
Comment at: compiler-rt/test/lit.common.cfg:332
+# Detect custom shadow scale.
+if config.asan_shadow_scale != '' and config.asan_shadow_scale != '3':
+  config.available_features.add("custom-shadow-scale")
----------------
vitalybuka wrote:
> waltl wrote:
> > vitalybuka wrote:
> > > can we see a patch where it's used?
> > https://reviews.llvm.org/D39774
> WDYT about "config.available_features.add("shadow-scale-%s" % (config.asan_shadow_scale if not empty else 3))"?
> 
> So you can replace "// UNSUPPORTED: custom-shadow-scale" with "// REQUIRES: shadow-scale-3"
> This allows to add some scale-5 specific tests
> 
> 
That sounds much better.  Thanks.



https://reviews.llvm.org/D39772