[PATCH] D40107: [AArch64] Remove obsoleted feature
Chad Rosier via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 16 05:53:37 PST 2017
mcrosier added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/arm64-ldp-cluster.ll:3
-; RUN: llc < %s -mtriple=arm64-linux-gnu -mcpu=cortex-a57 -verify-misched -debug-only=machine-scheduler -o - 2>&1 > /dev/null | FileCheck %s
-; RUN: llc < %s -mtriple=arm64-linux-gnu -mcpu=exynos-m1 -verify-misched -debug-only=machine-scheduler -o - 2>&1 > /dev/null | FileCheck --check-prefix=EXYNOS %s
----------------
fhahn wrote:
> Would it make sense to keep this check? It looks like it tests a code path that relied on `Paired128IsSlow` (@ldq_cluster) and it should behave the same now on exynos-m1/m2, without the subtarget feature.
+1
This should be a NFC after D39976, right?
================
Comment at: llvm/test/CodeGen/AArch64/no-quad-ldp-stp.ll:1
-; RUN: llc < %s -mtriple=aarch64-eabi -mattr=+slow-paired-128 -verify-machineinstrs -asm-verbose=false | FileCheck %s
-; RUN: llc < %s -mtriple=aarch64-eabi -mcpu=exynos-m1 -verify-machineinstrs -asm-verbose=false | FileCheck %s
----------------
I'd suggest we keep this file, but drop this RUN command since the slow-paired-128 feature will no longer exist.
Repository:
rL LLVM
https://reviews.llvm.org/D40107
More information about the llvm-commits
mailing list