[PATCH] D40025: [LLD] [COFF] Don't write long section names for sections that will be mapped at runtime

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 04:02:45 PST 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: COFF/Writer.cpp:548
+    // the string table that is unavailable at runtime.
+    if ((Sec->getPermissions() & IMAGE_SCN_MEM_DISCARDABLE) == 0)
+      continue;
----------------
Please also mention that this is different from MSVC link.exe but we found it is useful to have a section name like ".eh_fram" instead of something like "/4".


https://reviews.llvm.org/D40025





More information about the llvm-commits mailing list