[PATCH] D40070: [ELF] - Don't emit broken relocations for SHF_MERGE sections when --emit-relocs is used.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 03:38:53 PST 2017


grimar added a comment.

In https://reviews.llvm.org/D40070#927225, @ruiu wrote:

> Then it contradicts with the other comment in the same function.
>
>   // Create one STT_SECTION symbol for each output section we might
>   // have a relocation with.


Sorry, but I see no issue in this comment, probably my english is not good enough to see mistake in wording here.
What I think it is saying is that we create section symbols so that relocations that uses section symbols can use it, at least that
is what actually we do I believe.


https://reviews.llvm.org/D40070





More information about the llvm-commits mailing list