[PATCH] D40070: [ELF] - Don't emit broken relocations for SHF_MERGE sections when --emit-relocs is used.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Writer.cpp:495
+
+    // We do not create symbol for synthetic sections because do not have
+    // relocations that might use it, but SHF_MERGE sections is an exception
----------------
Synthetic sections don't have any relocations except mergeable sections. Mergeable output sections may have relocations because mergeable input sections may have relocations.


================
Comment at: test/ELF/emit-relocs-mergeable-i386.s:6
+
+## Check we produce proper relocations when doing merging of SHF_MERGE sections.
+
----------------
Check if 


================
Comment at: test/ELF/emit-relocs-mergeable.s:6
+
+## Check we produce proper relocations when doing merging of SHF_MERGE sections.
+
----------------
Check if



https://reviews.llvm.org/D40070