[PATCH] D38302: [X86][MC] Fixed crash when assembling a file that contains section with 64-bit alignment (PR34726)

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 15:44:43 PST 2017


probinson added a comment.

@rafael  this looks pretty benign to me, but MC is not my area.  What do you think?



================
Comment at: include/llvm/MC/MCFragment.h:296
   /// cannot be satisfied in this width then this fragment is ignored.
-  unsigned MaxBytesToEmit;
+  uint64_t MaxBytesToEmit;
 
----------------
Please reorder the fields so that the three 64-bit members are next to each other.  This will reduce the space wasted for padding.


https://reviews.llvm.org/D38302





More information about the llvm-commits mailing list