[PATCH] D39470: [asan] Fix size/alignment issues with non-default shadow scale

[Walter Lee via Phabricator via llvm-commits]

waltl added a comment.

In https://reviews.llvm.org/D39470#926732, @vitalybuka wrote:

> Not sure how the recent patch tests --asan-mapping-scale=5
>
> New tests could be additional "// RUN: opt... --asan-mapping-scale=5", with new CHECK prefixes 
>  or just new files, maybe copied from existing tests. Potential candidates: instrument-stack.ll, adaptive_global_redzones.ll


Yes this patch doesn't test -asan-mapping-scale=5.  That testing is added in https://reviews.llvm.org/D39775.  Most of the instrumentation tests directly under llvm/test/Instrumentation/AddressSanitizer will be enabled for shadow scale 5, including the ones that you mentioned.

The most recent change here adds a test to verify that the metadata_array is properly aligned for shadow scale 5, and it will be automatically enabled once https://reviews.llvm.org/D39775 is submitted.


https://reviews.llvm.org/D39470