[PATCH] D39845: [TableGen] Give the option of tolerating duplicate register names

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 15:07:43 PST 2017


mgrang added a comment.

Could you please add some tests?



================
Comment at: lib/TableGen/StringMatcher.cpp:53
   assert(!Matches.empty() && "Must have at least one string to match!");
   std::string Indent(IndentCount*2+4, ' ');
   
----------------
While you are at it could you also please fix the spacing here?
```
std::string Indent(IndentCount * 2 + 4, ' ');


https://reviews.llvm.org/D39845





More information about the llvm-commits mailing list