[llvm] r318334 - Simplify file handling in dsymutil.
Rafael Espindola via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 15 12:55:54 PST 2017
Author: rafael
Date: Wed Nov 15 12:55:53 2017
New Revision: 318334
URL: http://llvm.org/viewvc/llvm-project?rev=318334&view=rev
Log:
Simplify file handling in dsymutil.
This moves the file handling out of DwarfLinker.cpp.
This fixes what is at least an oddity if not a bug. DwarfLinker.cpp
was using ToolOutputFile, which uses RemoveFileOnSignal. The issue is
that dsymutil.cpp uses that too. It is now clear from the interface
that only dsymutil.cpp is responsible for creating and deleting files.
Modified:
llvm/trunk/tools/dsymutil/DwarfLinker.cpp
llvm/trunk/tools/dsymutil/dsymutil.cpp
llvm/trunk/tools/dsymutil/dsymutil.h
Modified: llvm/trunk/tools/dsymutil/DwarfLinker.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/DwarfLinker.cpp?rev=318334&r1=318333&r2=318334&view=diff
==============================================================================
--- llvm/trunk/tools/dsymutil/DwarfLinker.cpp (original)
+++ llvm/trunk/tools/dsymutil/DwarfLinker.cpp Wed Nov 15 12:55:53 2017
@@ -555,7 +555,7 @@ class DwarfStreamer {
/// @}
/// The file we stream the linked Dwarf to.
- std::unique_ptr<ToolOutputFile> OutFile;
+ raw_fd_ostream &OutFile;
uint32_t RangesSectionSize;
uint32_t LocSectionSize;
@@ -569,11 +569,8 @@ class DwarfStreamer {
const std::vector<CompileUnit::AccelInfo> &Names);
public:
- /// Actually create the streamer and the ouptut file.
- ///
- /// This could be done directly in the constructor, but it feels
- /// more natural to handle errors through return value.
- bool init(Triple TheTriple, StringRef OutputFilename);
+ DwarfStreamer(raw_fd_ostream &OutFile) : OutFile(OutFile) {}
+ bool init(Triple TheTriple);
/// Dump the file to the disk.
bool finish(const DebugMap &);
@@ -650,7 +647,7 @@ public:
} // end anonymous namespace
-bool DwarfStreamer::init(Triple TheTriple, StringRef OutputFilename) {
+bool DwarfStreamer::init(Triple TheTriple) {
std::string ErrorStr;
std::string TripleName;
StringRef Context = "dwarf streamer init";
@@ -692,16 +689,9 @@ bool DwarfStreamer::init(Triple TheTripl
if (!MCE)
return error("no code emitter for target " + TripleName, Context);
- // Create the output file.
- std::error_code EC;
- OutFile =
- llvm::make_unique<ToolOutputFile>(OutputFilename, EC, sys::fs::F_None);
- if (EC)
- return error(Twine(OutputFilename) + ": " + EC.message(), Context);
-
MCTargetOptions MCOptions = InitMCTargetOptionsFromFlags();
MS = TheTarget->createMCObjectStreamer(
- TheTriple, *MC, std::unique_ptr<MCAsmBackend>(MAB), OutFile->os(),
+ TheTriple, *MC, std::unique_ptr<MCAsmBackend>(MAB), OutFile,
std::unique_ptr<MCCodeEmitter>(MCE), *MSTI, MCOptions.MCRelaxAll,
MCOptions.MCIncrementalLinkerCompatible,
/*DWARFMustBeAtTheEnd*/ false);
@@ -729,13 +719,9 @@ bool DwarfStreamer::init(Triple TheTripl
bool DwarfStreamer::finish(const DebugMap &DM) {
bool Result = true;
if (DM.getTriple().isOSDarwin() && !DM.getBinaryPath().empty())
- Result = MachOUtils::generateDsymCompanion(DM, *MS, OutFile->os());
+ Result = MachOUtils::generateDsymCompanion(DM, *MS, OutFile);
else
MS->Finish();
-
- // Declare success.
- OutFile->keep();
-
return Result;
}
@@ -1210,9 +1196,8 @@ namespace {
/// first step when we start processing a DebugMapObject.
class DwarfLinker {
public:
- DwarfLinker(StringRef OutputFilename, const LinkOptions &Options)
- : OutputFilename(OutputFilename), Options(Options),
- BinHolder(Options.Verbose) {}
+ DwarfLinker(raw_fd_ostream &OutFile, const LinkOptions &Options)
+ : OutFile(OutFile), Options(Options), BinHolder(Options.Verbose) {}
/// Link the contents of the DebugMap.
bool link(const DebugMap &);
@@ -1535,7 +1520,7 @@ private:
/// \defgroup Helpers Various helper methods.
///
/// @{
- bool createStreamer(const Triple &TheTriple, StringRef OutputFilename);
+ bool createStreamer(const Triple &TheTriple, raw_fd_ostream &OutFile);
/// Attempt to load a debug object from disk.
ErrorOr<const object::ObjectFile &> loadObject(BinaryHolder &BinaryHolder,
@@ -1543,7 +1528,7 @@ private:
const DebugMap &Map);
/// @}
- std::string OutputFilename;
+ raw_fd_ostream &OutFile;
LinkOptions Options;
BinaryHolder BinHolder;
std::unique_ptr<DwarfStreamer> Streamer;
@@ -1876,12 +1861,12 @@ void DwarfLinker::reportWarning(const Tw
}
bool DwarfLinker::createStreamer(const Triple &TheTriple,
- StringRef OutputFilename) {
+ raw_fd_ostream &OutFile) {
if (Options.NoOutput)
return true;
- Streamer = llvm::make_unique<DwarfStreamer>();
- return Streamer->init(TheTriple, OutputFilename);
+ Streamer = llvm::make_unique<DwarfStreamer>(OutFile);
+ return Streamer->init(TheTriple);
}
/// Recursive helper to build the global DeclContext information and
@@ -3584,7 +3569,7 @@ void DwarfLinker::DIECloner::cloneAllCom
}
bool DwarfLinker::link(const DebugMap &Map) {
- if (!createStreamer(Map.getTriple(), OutputFilename))
+ if (!createStreamer(Map.getTriple(), OutFile))
return false;
// Size of the DIEs (and headers) generated for the linked output.
@@ -3744,9 +3729,9 @@ bool error(const Twine &Error, const Twi
return false;
}
-bool linkDwarf(StringRef OutputFilename, const DebugMap &DM,
+bool linkDwarf(raw_fd_ostream &OutFile, const DebugMap &DM,
const LinkOptions &Options) {
- DwarfLinker Linker(OutputFilename, Options);
+ DwarfLinker Linker(OutFile, Options);
return Linker.link(DM);
}
Modified: llvm/trunk/tools/dsymutil/dsymutil.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/dsymutil.cpp?rev=318334&r1=318333&r2=318334&view=diff
==============================================================================
--- llvm/trunk/tools/dsymutil/dsymutil.cpp (original)
+++ llvm/trunk/tools/dsymutil/dsymutil.cpp Wed Nov 15 12:55:53 2017
@@ -36,6 +36,7 @@
#include <string>
#include <system_error>
+using namespace llvm;
using namespace llvm::cl;
using namespace llvm::dsymutil;
@@ -358,7 +359,15 @@ int main(int argc, char **argv) {
std::string OutputFile = getOutputFileName(InputFile, NeedsTempFiles);
auto LinkLambda = [OutputFile, Options, &Map]() {
- if (OutputFile.empty() || !linkDwarf(OutputFile, *Map, Options))
+ if (OutputFile.empty())
+ exitDsymutil(1);
+ std::error_code EC;
+ raw_fd_ostream OS(NoOutput ? "-" : OutputFile, EC, sys::fs::F_None);
+ if (EC) {
+ errs() << OutputFile << ": " << EC.message();
+ exitDsymutil(1);
+ }
+ if (!linkDwarf(OS, *Map, Options))
exitDsymutil(1);
};
Modified: llvm/trunk/tools/dsymutil/dsymutil.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/dsymutil.h?rev=318334&r1=318333&r2=318334&view=diff
==============================================================================
--- llvm/trunk/tools/dsymutil/dsymutil.h (original)
+++ llvm/trunk/tools/dsymutil/dsymutil.h Wed Nov 15 12:55:53 2017
@@ -62,7 +62,7 @@ bool dumpStab(StringRef InputFile, Array
/// \brief Link the Dwarf debuginfo as directed by the passed DebugMap
/// \p DM into a DwarfFile named \p OutputFilename.
/// \returns false if the link failed.
-bool linkDwarf(StringRef OutputFilename, const DebugMap &DM,
+bool linkDwarf(raw_fd_ostream &OutFile, const DebugMap &DM,
const LinkOptions &Options);
/// \brief Exit the dsymutil process, cleaning up every temporary
More information about the llvm-commits
mailing list