[PATCH] D40078: [x86][icelake]VAES introduction

[coby via Phabricator via llvm-commits]

coby marked 3 inline comments as done.
coby added inline comments.


================
Comment at: lib/Support/Host.cpp:433
   FEATURE_SHA,
+  FEATURE_VAES,
 };
----------------
craig.topper wrote:
> This isn't needed if it isn't used by code in getHostCPUName
I see, thanks.
I assume same logic is to be applied to entries like FEATURE_PCLMUL?


================
Comment at: lib/Target/X86/X86InstrInfo.td:829
+def HasVAES      : Predicate<"Subtarget->hasVAES()">,
+                    AssemblerPredicate<"FeatureVAES",
+                      "AES instructions on AVX512 registers">;
----------------
craig.topper wrote:
> I don't think you nee the assembler predicate. We only need it on the core AVX512 features because it enables the parser to recognize mask registers and embeded rounding. In general we don't do fine grained control of what instructinos are available to the assembler.
verified it to be right. thanks. will remove


Repository:
  rL LLVM

https://reviews.llvm.org/D40078