[lld] r318310 - Remove an unnecessary constraint.

[Rafael Espindola via llvm-commits]

Author: rafael
Date: Wed Nov 15 09:31:27 2017
New Revision: 318310

URL: http://llvm.org/viewvc/llvm-project?rev=318310&view=rev
Log:
Remove an unnecessary constraint.

Our current implementation of SHF_MERGE can already handle over
aligned elements.

Added:
    lld/trunk/test/ELF/merge-align.s
Modified:
    lld/trunk/ELF/InputFiles.cpp

Modified: lld/trunk/ELF/InputFiles.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=318310&r1=318309&r2=318310&view=diff
==============================================================================
--- lld/trunk/ELF/InputFiles.cpp (original)
+++ lld/trunk/ELF/InputFiles.cpp Wed Nov 15 09:31:27 2017
@@ -319,16 +319,7 @@ template <class ELFT> bool ObjFile<ELFT>
   if (Flags & SHF_WRITE)
     fatal(toString(this) + ": writable SHF_MERGE section is not supported");
 
-  // Don't try to merge if the alignment is larger than the sh_entsize and this
-  // is not SHF_STRINGS.
-  //
-  // Since this is not a SHF_STRINGS, we would need to pad after every entity.
-  // It would be equivalent for the producer of the .o to just set a larger
-  // sh_entsize.
-  if (Flags & SHF_STRINGS)
-    return true;
-
-  return Sec.sh_addralign <= EntSize;
+  return true;
 }
 
 template <class ELFT>

Added: lld/trunk/test/ELF/merge-align.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/merge-align.s?rev=318310&view=auto
==============================================================================
--- lld/trunk/test/ELF/merge-align.s (added)
+++ lld/trunk/test/ELF/merge-align.s Wed Nov 15 09:31:27 2017
@@ -0,0 +1,34 @@
+// REQUIRES: x86
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+// RUN: ld.lld %t.o -o %t.so -shared
+// RUN: llvm-readobj -s -section-data %t.so | FileCheck %s
+
+        .section        .rodata.foo,"aM", at progbits,1
+        .align  16
+        .byte 0x42
+
+        .section        .rodata.bar,"aM", at progbits,1
+        .align  16
+        .byte 0x42
+
+        .section        .rodata.zed,"aM", at progbits,1
+        .align  16
+        .byte 0x41
+
+// CHECK:      Name: .rodata (
+// CHECK-NEXT: Type: SHT_PROGBITS
+// CHECK-NEXT: Flags [
+// CHECK-NEXT:   SHF_ALLOC
+// CHECK-NEXT:   SHF_MERGE
+// CHECK-NEXT: ]
+// CHECK-NEXT: Address:
+// CHECK-NEXT: Offset:
+// CHECK-NEXT: Size: 17
+// CHECK-NEXT: Link: 0
+// CHECK-NEXT: Info: 0
+// CHECK-NEXT: AddressAlignment: 16
+// CHECK-NEXT: EntrySize: 1
+// CHECK-NEXT: SectionData (
+// CHECK-NEXT:   0000: 42000000 00000000 00000000 00000000  |
+// CHECK-NEXT:   0010: 41                                   |
+// CHECK-NEXT: )