[PATCH] D40026: [ELF] - Allow applying SHF_MERGE optimization for relocatable output.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Writer.cpp:494
+    // which is used for -r.
+    if (isa<SyntheticSection>(IS) && !(IS->Flags & SHF_MERGE))
+      continue;
----------------
grimar wrote:
> ruiu wrote:
> > I wonder if you really need to handle this as a special case.
> Do you mean we can create symbols for all synthetic sections instead ? I think that is at least confusing to see in output and excessive.
Well, I mean I actually do not understand what this code is for in the first place.


https://reviews.llvm.org/D40026