[PATCH] D40032: [compiler-rt] Replace forkpty with posix_spawn

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added a comment.

I can't say that I fully understand what happens here, but I can rubber stamp LGTM if you wish.

FWIW for linux we have a bunch of checks if we are in symbolizer in interceptors, and do something different if we are.



================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:229
+
+  slave_fd = open(slave_pty_name, O_RDWR);
+  if (slave_fd == -1) goto cleanup;
----------------
Don't we want to use internal_open/internal_close here? open/close are intercepted.


Repository:
  rL LLVM

https://reviews.llvm.org/D40032