[PATCH] D40025: [LLD] [COFF] Always truncate the .eh_frame section name

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 23:36:02 PST 2017


ruiu added inline comments.


================
Comment at: COFF/Writer.cpp:544
       continue;
+    if (Name == ".eh_frame" && Config->MinGW)
+      continue;
----------------
I'd prefer doing this at the very early stage instead of this late. Can you modify InputFiles.cpp so that a section with name ".eh_frame" is read as if ".eh_fram"?

I also wonder if there's a problem if we do not limit it to MinGW. Generally I'd try reducing "if (MinGW)" code, so if we can do this unconditionally, we should do that unconditionally.


https://reviews.llvm.org/D40025





More information about the llvm-commits mailing list