[PATCH] D40019: [LLD] [MinGW] Implement the --[no-]gc-sections and --icf options

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: MinGW/Driver.cpp:173
     Add("-tsaware:no");
   if (Args.hasArg(OPT_high_entropy_va))
     Add("-highentropyva");
----------------
Please add a blank line before a new if ~ else if ~ else block.


================
Comment at: MinGW/Driver.cpp:188
+    else
+      Add("-opt:noicf");
+  } else {
----------------
Don't you want to report an error for an unknown argument?


https://reviews.llvm.org/D40019