[PATCH] D40063: Propagate sh_entsize out

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 21:41:16 PST 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SyntheticSections.cpp:2517
     auto I = llvm::find_if(MergeSections, [=](MergeSyntheticSection *Sec) {
+      // We could ignore Entsize in here: We would create a single Syncthetic
+      // section for two different values of Entsize. That would work, but no
----------------
Can you reword this comment a bit? I mean, at first I thought this comment explained that the code have ignored Entsize which isn't true.


https://reviews.llvm.org/D40063





More information about the llvm-commits mailing list