[PATCH] D39453: [SCEV] Strengthen variance condition in calculateLoopDisposition

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Max and I discussed and realized this comes down to simply needing a much simpler and straight-forward comment.  :)  If AR is not defined on entry to L, it can't be LoopInvariant with respect to L.  The distinction between L being a parent of AR->loop vs a sibling vs a nephew, cousin, etc... really doesn't contribute anything here.

The fact we use LoopVariant to represent "not defined on entry" is slightly confusing, but the code already does that for other cases.

I asked Max to update the comment and add a nephew loop example to the test.


https://reviews.llvm.org/D39453