[PATCH] D40040: [AMDGPU] Fix SITargetLowering::LowerCall for pointer info of byval argument

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:2284
+            MachinePointerInfo(UndefValue::get(Type::getInt8PtrTy(
+                *DAG.getContext(), AMDGPUASI.PRIVATE_ADDRESS))));
 
----------------
arsenm wrote:
> arsenm wrote:
> > I think this should be a Stack PseudoSourceValue, but don't remember why it isn't
> The destination is a Stack PSV. The source I guess is unknown. We do need to figure out something other than undef for these
The source is a pointer in private address space, other than that we don't know anything about the source. For example, in the lit test the source is inttoptr i32 16 to i8 addrspace(5)*. At the point of isel, this source is a constant integer 16. Currently there is no PSV to represent address space only. At least llvm undef value conveys the address space information.


https://reviews.llvm.org/D40040