[PATCH] D40057: Simplify file handling in dsymutil

[Rafael Ávila de Espíndola via Phabricator via llvm-commits]

rafael created this revision.
Herald added a subscriber: aprantl.

I am trying to unify llvm's temporary file handling around TempFile.

This is a step towards using it in dsymutil. It just moves the file handling out of DwarfLinker.cpp.

This fixes what is at least an oddity if not a bug. DwarfLinker.cpp was using ToolOutputFile, which uses RemoveFileOnSignal. The issue is that dsymutil.cpp uses that too. It is now clear from the interface that only dsymutil.cpp is responsible for creating and deleting files.


https://reviews.llvm.org/D40057

Files:
  tools/dsymutil/DwarfLinker.cpp
  tools/dsymutil/dsymutil.cpp
  tools/dsymutil/dsymutil.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40057.122950.patch
Type: text/x-patch
Size: 6135 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171115/70782c6c/attachment-0001.bin>