[llvm] r318206 - [CodeGen] Fix the test case added in r318202

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 15:39:53 PST 2017


I think keeping the triple still makes sense, since the test
expectations are x86_64-specific.

On Tue, Nov 14, 2017 at 3:35 PM, Rong Xu <xur at google.com> wrote:
> Thanks Hans for the help!
>
> With this fix, looks -mtriple=x86_64-linux-gnu is no longer needed.
>
> I will leave it for now. Will clean it up once this patch stabilizes.
>
> Regards,
>
> -Rong
>
> On Tue, Nov 14, 2017 at 3:30 PM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> Should be fixed with r318220.
>>
>> On Tue, Nov 14, 2017 at 3:07 PM, Hans Wennborg <hans at chromium.org> wrote:
>> > There seems to be another error on some bots, for example:
>> >
>> > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13503/steps/test/logs/stdio
>> >
>> > $
>> > "C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.obj\bin\llc.EXE"
>> > "-mtriple=x86_64-linux-gnu" "-stop-after=isel"
>> > # command stderr:
>> > LLVM ERROR: "isel" pass is not registered.
>> >
>> > On Tue, Nov 14, 2017 at 2:08 PM, Rong Xu via llvm-commits
>> > <llvm-commits at lists.llvm.org> wrote:
>> >> Author: xur
>> >> Date: Tue Nov 14 14:08:37 2017
>> >> New Revision: 318206
>> >>
>> >> URL: http://llvm.org/viewvc/llvm-project?rev=318206&view=rev
>> >> Log:
>> >> [CodeGen] Fix the test case added in r318202
>> >>
>> >> Add the -mtriple option to filter some platforms.
>> >>
>> >> Modified:
>> >>     llvm/trunk/test/CodeGen/X86/switch-lower-peel-top-case.ll
>> >>
>> >> Modified: llvm/trunk/test/CodeGen/X86/switch-lower-peel-top-case.ll
>> >> URL:
>> >> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/switch-lower-peel-top-case.ll?rev=318206&r1=318205&r2=318206&view=diff
>> >>
>> >> ==============================================================================
>> >> --- llvm/trunk/test/CodeGen/X86/switch-lower-peel-top-case.ll
>> >> (original)
>> >> +++ llvm/trunk/test/CodeGen/X86/switch-lower-peel-top-case.ll Tue Nov
>> >> 14 14:08:37 2017
>> >> @@ -1,4 +1,4 @@
>> >> -; RUN: llc -stop-after=isel < %s  | FileCheck %s
>> >> +; RUN: llc -mtriple=x86_64-linux-gnu -stop-after=isel < %s  |
>> >> FileCheck %s
>> >>
>> >>  define i32 @foo(i32 %n) !prof !1 {
>> >>  entry:
>> >>
>> >>
>> >> _______________________________________________
>> >> llvm-commits mailing list
>> >> llvm-commits at lists.llvm.org
>> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>


More information about the llvm-commits mailing list