[PATCH] D40017: [LLD] [MinGW] Add support for --dynamicbase, ignore --nxcompat, --tsaware and --high-entropy-va
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 14 15:01:47 PST 2017
ruiu accepted this revision.
ruiu added a comment.
LGTM
================
Comment at: MinGW/Driver.cpp:159
Add("-largeaddressaware");
+ if (Args.hasArg(OPT_dynamicbase))
+ Add("-dynamicbase");
----------------
nit: add a blank line so that this code block doesn't look like a series of if ~ else if ~ else if ~ else. Or maybe you could use :?
https://reviews.llvm.org/D40017
More information about the llvm-commits
mailing list