[LNT] r318196 - Add back some missing sessions
Chris Matthews via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 14 14:54:46 PST 2017
My editor’s linter warned that they were undefined.
> On Nov 14, 2017, at 2:36 PM, Matthias Braun <mbraun at apple.com> wrote:
>
> Thanks for the fix. How did you notice something is broken? Did you notice the pages are broken by reading the sourcecode or because you use those pages?
> (I've got the feeling both endpoints aren't really used and obviously lack unit tests, making me wonder if it would make sense to throw them out...)
>
> - Matthias
>
>> On Nov 14, 2017, at 1:12 PM, Chris Matthews via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: cmatthews
>> Date: Tue Nov 14 13:12:18 2017
>> New Revision: 318196
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=318196&view=rev
>> Log:
>> Add back some missing sessions
>>
>> Modified:
>> lnt/trunk/lnt/server/ui/views.py
>>
>> Modified: lnt/trunk/lnt/server/ui/views.py
>> URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/views.py?rev=318196&r1=318195&r2=318196&view=diff
>> ==============================================================================
>> --- lnt/trunk/lnt/server/ui/views.py (original)
>> +++ lnt/trunk/lnt/server/ui/views.py Tue Nov 14 13:12:18 2017
>> @@ -453,6 +453,7 @@ def v4_text_report(id):
>> def simple_run(tag, id):
>> # Get the expected test suite.
>> db = request.get_db()
>> + session = request.session
>> ts = db.testsuite[tag]
>>
>> # Look for a matched run.
>> @@ -1448,6 +1449,7 @@ def get_summary_config_path():
>> @db_route("/summary_report/edit", methods=('GET', 'POST'))
>> def v4_summary_report_ui():
>> # If this is a POST request, update the saved config.
>> + session = request.session
>> if request.method == 'POST':
>> # Parse the config data.
>> config_data = request.form.get('config')
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
More information about the llvm-commits
mailing list