[PATCH] D40050: CMake: Turn LLVM_ENABLE_LIBXML2 into a tri-state option
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 14 14:25:37 PST 2017
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: cmake/config-ix.cmake:163
set(LIBXML2_FOUND 0)
if((LLVM_ENABLE_LIBXML2) AND ((CMAKE_SYSTEM_NAME MATCHES "Linux") AND (ICONV_LIBRARY_PATH) OR APPLE))
find_package(LibXml2)
----------------
I guess the string value OFF evaluates to false in this context? Scary loose typing, batman!
https://reviews.llvm.org/D40050
More information about the llvm-commits
mailing list