[PATCH] D39731: AMDGPU: Don't use MUBUF vaddr if address may overflow

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 14:25:36 PST 2017


arsenm updated this revision to Diff 122914.
arsenm added a comment.

Don't rely on NUW. Even if it's -1 + 0, the final add of soffset will overflow


https://reviews.llvm.org/D39731

Files:
  lib/Target/AMDGPU/AMDGPU.td
  lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
  lib/Target/AMDGPU/AMDGPUSubtarget.cpp
  lib/Target/AMDGPU/AMDGPUSubtarget.h
  lib/Target/AMDGPU/SIISelLowering.cpp
  lib/Target/AMDGPU/SIISelLowering.h
  test/CodeGen/AMDGPU/amdgpu.private-memory.ll
  test/CodeGen/AMDGPU/array-ptr-calc-i32.ll
  test/CodeGen/AMDGPU/frame-index-elimination.ll
  test/CodeGen/AMDGPU/function-returns.ll
  test/CodeGen/AMDGPU/huge-private-buffer.ll
  test/CodeGen/AMDGPU/load-hi16.ll
  test/CodeGen/AMDGPU/load-lo16.ll
  test/CodeGen/AMDGPU/scratch-buffer.ll
  test/CodeGen/AMDGPU/store-hi16.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39731.122914.patch
Type: text/x-patch
Size: 48075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171114/895ec7a4/attachment.bin>


More information about the llvm-commits mailing list