[PATCH] D39021: [llvm-objcopy] Add support for --only-keep and the special way it interacts with -O binary

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

Yikes, here's an update on what GNU objcopy does. It interprets "keep" and "remove" differently. Namely, "keep" is not "remove all but". If you "remove" and "keep" a section then an error is thrown. --only-keep appears to be "remove all but" plus "keep". I don't think this behavior is so terrible to implement. We would implement --only-keep so that it, in an order independent way, removes all sections but the named one (and certain special sections obviously) then additionally adds the section to a keep list. We then, before performing removal, iterate though the keep list to see if we're about to remove anything on the keep list. If we detect that we are, we throw an error. This a general way of implementing this keep functionality so as new options come up there will be a standard way of handling it.


Repository:
  rL LLVM

https://reviews.llvm.org/D39021