[PATCH] D39990: Use TempFile in the implementation of LockFileManager

[Ben Langmuir via Phabricator via llvm-commits]

benlangmuir requested changes to this revision.
benlangmuir added a subscriber: bruno.
benlangmuir added a comment.
This revision now requires changes to proceed.

Spotted one issue, but otherwise seems okay to me.  I'd like @bruno to take a look at this, because he's thought about this code much more recently than me.



================
Comment at: lib/Support/LockFileManager.cpp:128
+class RAIICleanup {
+  function_ref<void()> Fn;
+  bool Canceled = false;
----------------
The constructor is being called with a temporary lambda, so this is going to create a use-after-free.


https://reviews.llvm.org/D39990