[PATCH] D39992: [CodeGenPrepare] Disable div bypass when working set size is huge.

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 10:54:22 PST 2017


As David had replied OptSize and hasHugeWorkingSetSize have some similarity
but still different. For instance, inlining of hot callsites is still
aggressive when hasHugeWorkingSetSize is true. If you are suggesting adding
a separate function attribute similar to optsize but based on the profile
based working set data, I am not sure how useful that is since it is never
function specific.

On Mon, Nov 13, 2017 at 5:44 PM, Eli Friedman via Phabricator <
reviews at reviews.llvm.org> wrote:

> efriedma added a comment.
>
> It seems like OptSize and hasHugeWorkingSetSize overlap a lot (a lot of
> large C++ codebases use -Os to help fit into the icache).  Would it make
> sense to automatically add OptSize markings based on profile data, or
> something like that, rather than adding hasHugeWorkingSetSize() checks all
> over the compiler?
>
>
> https://reviews.llvm.org/D39992
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171114/a4c0b09e/attachment.html>


More information about the llvm-commits mailing list