[PATCH] D31025: [Docs] Add tablegen backend for target opcode documentatio

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls accepted this revision.
kristof.beyls added a comment.
This revision is now accepted and ready to land.

LGTM, modulo the one comment about the file header.



================
Comment at: utils/TableGen/InstrDocsEmitter.cpp:1-7
+#include "CodeGenDAGPatterns.h"
+#include "CodeGenInstruction.h"
+#include "CodeGenTarget.h"
+#include "TableGenBackends.h"
+#include "llvm/TableGen/Record.h"
+#include <string>
+#include <vector>
----------------
This new file needs a header.


================
Comment at: utils/TableGen/InstrDocsEmitter.cpp:52-54
+    // Don't print the target-independent instructions.
+    if (II->Namespace == "TargetOpcode")
+      continue;
----------------
It's probably debatable whether it's useful or not to also print documentation for the target-independent instructions. But let's leave this as is for now.


Repository:
  rL LLVM

https://reviews.llvm.org/D31025