[PATCH] D40010: [XRay] [test-suite] Add FDR mode microbenchmark

[Dean Michael Berris via Phabricator via llvm-commits]

dberris requested changes to this revision.
dberris added inline comments.
This revision now requires changes to proceed.


================
Comment at: MicroBenchmarks/XRay/FDRMode/CMakeLists.txt:11
 
-  file(COPY retref-bench_BM_ReturnNeverInstrumented.test
+  file(COPY fdrmode-bench_BM_XRayFDRMultiThreaded_threads:1.test
        DESTINATION ${CMAKE_CURRENT_BINARY_DIR})
----------------
Not sure if all systems will be happy with a colon in the filename of the test... can we use a less extraordinary character here? Say another `-` or `_` instead?


================
Comment at: MicroBenchmarks/XRay/FDRMode/fdrmode-bench.cc:1
+#include <assert.h>
+#include <fcntl.h>
----------------
Please put the same license (LLVM license) in the header of this file. Use similar language to the one we put on the ReturnReference benchmarks.


https://reviews.llvm.org/D40010