[PATCH] D39888: [lsan] Only use VM_MEMORY_OS_ALLOC_ONCE on Darwin versions that support it

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 03:27:12 PST 2017


ro added a comment.

I meant to add the URL immediately ;-)

You mean using __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__?  Directly in lsan/lsan_common.h?  Checking now, I see
that there's a single use in sanitizer_common/sanitizer_platform_interceptors.h already.

I still find it very hard to determine what kind of preprocessor conditional use is and isn't acceptable inside LLVM, so please bear with me.


https://reviews.llvm.org/D39888





More information about the llvm-commits mailing list