[PATCH] D40011: [TableGen] AsmMatcher: Fix bug with reported diagnostic for operand.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen created this revision.
Herald added a subscriber: javed.absar.

The generated diagnostic by the AsmMatcher isn't always applicable to the AsmOperand.

This is because the code will only update the diagnostic if it is more specific than the previous diagnostic. However, when having validated operands and 'moved on' to a next operand (for some instruction/alias for which all previous operands are valid), if the diagnostic is InvalidOperand, than that should be set as the diagnostic, not the more specific message about a previous operand for some other instruction/alias candidate.


https://reviews.llvm.org/D40011

Files:
  test/MC/AArch64/arm64-diags.s
  test/MC/AArch64/basic-a64-diagnostics.s
  utils/TableGen/AsmMatcherEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40011.122802.patch
Type: text/x-patch
Size: 7650 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171114/36a8a7ce/attachment.bin>