[PATCH] D39713: [llvm-objcopy] Change -O binary to respect section removal and behave like GNU objcopy

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 02:47:19 PST 2017


jhenderson added a comment.

Oops, I should have spotted that as well.

Although I think the alignment change is tested as part of parent-loop-check.test, I think it should have its own explicit test, to make it easier to see what is being tested. Please could you add one.



================
Comment at: test/tools/llvm-objcopy/parent-loop-check.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-objcopy -R=.note -O binary %t %t2
----------------
Could you add a comment to the top of this test case to explain what is special about this case, please.


Repository:
  rL LLVM

https://reviews.llvm.org/D39713





More information about the llvm-commits mailing list