[PATCH] D39973: Fix CaptureTracking for llvm.invariant.group.barrier

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

This is a workaround for invariant.group.barrier not having a mangled type. That should probably be fixed instead. The others already do, so it doesn't make sense that group.barrier does not



================
Comment at: test/CodeGen/AMDGPU/promote-alloca-invariant-markers.ll:2
+; RUN:  llc -amdgpu-scalarize-global-loads=false  -march=amdgcn -mtriple=amdgcn---amdgiz -mattr=+promote-alloca -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
+target datalayout = "A5"
 
----------------
yaxunl wrote:
> arsenm wrote:
> > Why is it necessary to add this? The datalayout is implied by the explicit triple
> Removing this will cause error:
> 
> llc: <stdin>:13:31: error: address space must match datalayout
>   %tmp = alloca i32, align 4, addrspace(5)
> 
This sounds like a bug. This should be coming from the datalayout


https://reviews.llvm.org/D39973