[PATCH] D39968: [COFF] Ignore semicolons in module definition identifiers

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 13 17:39:00 PST 2017


ruiu added a comment.

> The NSS project's .def files make heavy use of semicolons in a frightening attempt at portability: https://hg.mozilla.org/projects/nss/raw-file/tip/lib/ckfw/capi/nsscapi.def

Ooh, that's an amazing piece of super hacky code. It's even funny. :) It feels like it would probably be much easier to prepare separate file for each platform.

Anyway, I believe this patch is fine, but can you add a testcase?


https://reviews.llvm.org/D39968





More information about the llvm-commits mailing list