[PATCH] D39972: [LLD] [COFF] Support ENTRY and SUBSYSTEM in .drectve sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Can you add a test?



================
Comment at: COFF/Driver.cpp:249
+    case OPT_entry:
+      Config->Entry = addUndefined(mangle(Arg->getValue()));
+      break;
----------------
Are you really sure if you need `mangle`? IIRC, there are some command line options that behave differently in terms of name mangling when they are given via .drctve section, so I wonder if that is not the case for /entry.


https://reviews.llvm.org/D39972