[PATCH] D39084: [PM] Port BoundsChecking to the new PM.

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added a comment.

LGTM modulo comments. I thought we were done with this monkey work.



================
Comment at: llvm/include/llvm/Transforms/Instrumentation/BoundsChecking.h:17
+
+class Function;
+
----------------
Do you need Function to be declared here otherwise you get an error?


================
Comment at: llvm/include/llvm/Transforms/Instrumentation/BoundsChecking.h:19
+
+/// A pass to instrument code and perform run-time bounds checking on loads, stores, and other memory intrinsics.
+struct BoundsCheckingPass : PassInfoMixin<BoundsCheckingPass> {
----------------
This comment seems repeated twice, I think one of the two instances can be removed (this very one seems also not clang-formatte'd)


================
Comment at: llvm/include/llvm/Transforms/Instrumentation/BoundsChecking.h:27
+// checking on loads, stores, and other memory intrinsics.
+FunctionPass *createBoundsCheckingLegacyPass();
+
----------------
We generally don't put the old `create*` API in the header, is there a particular reason why this is here?


https://reviews.llvm.org/D39084